-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion functions for authStore types #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I think the enums with _
are fine.
I think the JSONSchema for Role should include UNRECOGNIZED
as an enum option, rather than trying to use a default, and the client should handle that accordingly. This is for future compatibility so that a new action does not break existing clients.
Needs changes from master merged in, for the const: schemaName change.
Ok, I see that, for example, the |
Ah good point. I initially had initially thought that a It's a different case with the |
Things to consider:
protobuf doesn't allow colons (':') on identifiers, so to avoid type problems I basically replaced that delimiter with underscore ('_'). So in schemas
role:set
becomesrole_set
. Another separator could be chosen, or a convertion function (convertAction) could be written; I've tried but failed with that